On 05/06/2014 07:07 AM, Benoît Canet wrote: > > common.json being included in block-core.json and in qapi-schema.json it > quickly lead some code being generated in double and the compilation to choke. > > What do you think would be the best solution to fix this ? > (Fix the generator ? Make include ignore second inclusion of the same file ?)
I'd argue for the latter - update the parser and the documentation to state that if a file is included twice, the second inclusion does nothing. Obviously, the testsuite needs enhancement to test the solution, as well. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
