Eric Blake <ebl...@redhat.com> writes: > On 05/05/2014 12:49 AM, Markus Armbruster wrote: >> Eric Blake <ebl...@redhat.com> writes: >> > >>>> Example: >>>> >>>> mdroth@illuin:~/w/qemu2.git$ cat qapi-generated/example-qmp-marshal.c >>> >>> The file was missing the example command line that generated this file; >>> I figured it out: >>> >>> mdroth@illuin:~/w/qemu2.git$ python scripts/qapi-commands.py \ >>> --output-dir="qapi-generated" --prefix="example-" < >>> example-schema.json >>> >>> if you want to add that to this patch. >> >> Sure, why not, but if there's nothing else to correct in this series, >> I'd prefer a separate commit to a respin. > > Followup commit is just fine, if I don't turn up anything else while > reviewing the rest of the series.
Followup commit. because my fix conflicts with a patch in Luiz's queue. I'll wait for that to land, then post my fix on top.
