Eric Blake <ebl...@redhat.com> writes: > On 05/02/2014 06:44 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> docs/qapi-code-gen.txt | 146 >> ++++++++++++++++++++++++++++++------------------- >> 1 file changed, 90 insertions(+), 56 deletions(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > I checked that this matches the current reality, and serves as a good > metric for what the rest of the series cleans up. > >> === scripts/qapi-commands.py === >> >> Used to generate the marshaling/dispatch functions for the commands defined >> @@ -356,18 +395,8 @@ $(prefix)qmp-commands.h: Function prototypes for the >> QMP commands >> Example: >> >> mdroth@illuin:~/w/qemu2.git$ cat qapi-generated/example-qmp-marshal.c > > The file was missing the example command line that generated this file; > I figured it out: > > mdroth@illuin:~/w/qemu2.git$ python scripts/qapi-commands.py \ > --output-dir="qapi-generated" --prefix="example-" < > example-schema.json > > if you want to add that to this patch.
Sure, why not, but if there's nothing else to correct in this series, I'd prefer a separate commit to a respin.
