Eric Blake <ebl...@redhat.com> writes: > On 05/02/2014 06:44 AM, Markus Armbruster wrote: >> In preparation of error handling changes. Bonus: generates less >> duplicated code. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> scripts/qapi-visit.py | 48 ++++++++++++++++++++++++++++++++++-------------- >> 1 file changed, 34 insertions(+), 14 deletions(-) > > Too bad the example txt file didn't cover this case, to show the > difference in the generated code.
Yes. I considered extending the example in docs/qapi-code-gen.txt, but I'm afraid our schema language has become too big for complete coverage in that example. tests/qapi-schema-test.json should use every schema language feature. The code generated for it isn't in git, though. To see diffs, so you have to apply patches, make check, and compare tests/test-q*.[ch] by hand. > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!
