On 03/04/2014 07:00 AM, Paolo Bonzini wrote: > From: Wanlong Gao <gaowanl...@cn.fujitsu.com> > > If the total number of the assigned numa nodes memory is not > equal to the assigned ram size, it will write the wrong data > to ACPI talb, then the guest will ignore the wrong ACPI table
s/talb/table/ > and recognize all memory to one node. It's buggy, we should > check it to ensure that we write the right data to ACPI table. > > Signed-off-by: Wanlong Gao <gaowanl...@cn.fujitsu.com> > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > numa.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > + if (numa_total != ram_size) { > + fprintf(stderr, "qemu: numa nodes total memory size " > + "should equal to ram_size\n"); Is it worth also printing numa_total or ram_size values in this error message? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature