On Tue, Jan 21, 2014 at 11:03:15AM +0100, Paolo Bonzini wrote: > Il 20/01/2014 23:13, Andreas Färber ha scritto: > > I don't like the argument that we can put arbitrary stuff in our model > > definitions and rely on TCG not having implemented it to make it > > correct. Is x2apic something that TCG can never implement for some > > reason? Then that needs a better explanation. Otherwise, is there no > > criteria we can add this flag for when kvm_enabled()? > > We already do that for other bits (e.g. XSAVE/OSXSAVE), and in fact it > is the same that we do for KVM: the KVM_GET_SUPPORTED_CPUID result is > used to trim the generic feature bits.
The only difference is that the "check" and "enforce" flags won't work in TCG mode. But I plan to change this soon. -- Eduardo
