From: Markus Armbruster <arm...@redhat.com> Pointer properties can be set only by code, not by device_add. A device with a pointer property can't work with device_add only unless the property may remain null. cannot_instantiate_with_device_add_yet needs to be set then. PATCH 1/2 sets it when needed and else documents why not. PATCH 2/2 documents this for future users of pointer properties.
This applies on top of my "[PATCH v4 00/10] Clean up and fix no_user" series. Markus Armbruster (2): hw: cannot_instantiate_with_device_add_yet due to pointer props qdev: Document that pointer properties kill device_add hw/audio/marvell_88w8618.c | 2 ++ hw/dma/sparc32_dma.c | 2 ++ hw/gpio/omap_gpio.c | 4 ++++ hw/i2c/omap_i2c.c | 2 ++ hw/i2c/smbus_eeprom.c | 2 ++ hw/intc/etraxfs_pic.c | 4 ++++ hw/intc/grlib_irqmp.c | 2 ++ hw/intc/omap_intc.c | 4 ++++ hw/net/etraxfs_eth.c | 2 ++ hw/net/lance.c | 2 ++ include/hw/qdev-properties.h | 17 +++++++++++++++++ 11 files changed, 43 insertions(+) -- 1.8.1.4