On Tue, Jul 23, 2013 at 11:10:45AM +0200, Andreas Färber wrote: > Am 23.07.2013 09:07, schrieb Michael S. Tsirkin: > > On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas Färber wrote: > >> For VMState I believe the real follow-up fix would be mst defining a > >> central macro VMSTATE_PCI_DEVICE_AER_LOG() operating on PCIDevice. > >> Why is that separate from VMSTATE_PCI_DEVICE() or VMSTATE_PCIE_DEVICE() > >> in the first place? > > > > The real fix is savevm/loadvm taking into account > > the class hierarchy. > > That's not helping, unless you write a patch to show what you mean and
I merely mean that if I inherit a class I should inherit it's vmstate. So explicitly adding VMSTATE_PCI_DEVICE should not be necessary. > how that is going to be migration-compatible. Most devices put VMSTATE_PCI_DEVICE at the beninning, so just calling that before vmstate for the device should be compatible. > Does your not answering the question mean you don't know? > > Andreas I think the answer is that most pcie devices don't implement AER. AFAIK PCI devices can't support AER at all. > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
