Am 22.07.2013 19:22, schrieb Andreas Färber: > Am 21.07.2013 22:26, schrieb Michael S. Tsirkin: >> On Sun, Jul 21, 2013 at 04:09:00PM +0200, Andreas Färber wrote: >>> Hello Michael et al., >>> >>> This series turns PCIBridge, PCIEPort and PCIESlot into abstract QOM types, >>> so that we can use QOM casts to obtain a pointer. >>> >>> Possibly this was prompted by q35's PCIe? >> >> What was prompted? > > This refactoring series. > >> What's the question exactly? > > Why I prepared this series on an offline train ride on Wednesday. ;) Not > for you to answer - something PCIe must've gotten in the way of some QOM > realize conversion but the branch is missing the final patch showing > what these types and casts are good for.
Doh, stumbled over it again: pci_bridge_initfn() should become PCIBridge's realizefn, and walking down the type hierarchy pcie_port_init_reg() should become PCIEPort's (which needs TYPE_PCIE_PORT), etc. That's a bigger refactoring though, so v2 will come without it. Andreas > Since we're in Soft Freeze I > rather wanted to flush my queues for review though rather than spend > more time puzzling why I did this. :) > > Andreas > >> >>> Don't remember ATM... >>> >>> Regards, >>> Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
