On Jun 24, 2013, at 3:07 PM, Anthony Liguori wrote: > Stacey Son <s...@freebsd.org> writes: > >> On Jun 24, 2013, at 12:55 PM, Anthony Liguori wrote: >> >>> There is no humanly way 23k LOC can be reviewed in a single series. >> >> Yes, indeed, it is a lot of code. >> >>> Has this been maintained out of tree for some time? >> >> Yes, it has been a large, ugly patch set in the FreeBSD qemu-devel >> port for some time. > > Okay, I assume there were many collaborators then? You may want to > consider collecting some additional Signed-off-bys then from the > original authors. I don't like the idea merging a very large patch > series without preserving authorship info.
No, not a lot of collaborators and most of the code comes from me. The exceptions are: (1) A lot of the arm dependent code comes from Olivier Houchard. He also added some some system call shims. I noted this in the cover letter but, yes, I should add signed-off-bys and you pointed out. (2) Some of the system call shims comes from the linux-user code. (3) I have some initial ppc dependent from Andreas Tobler. Of course, none of that code is included (yet). (4) Juergen Lock, who maintains the FreeBSD port, has given me build patches for older (and supported) FreeBSD versions. >> >>> Is it largely >>> copy/paste from linux-user? >> >> A good amount of the initial code came from linux-user but then >> diverged when the code was restructured to put cpu and *BSD dependent >> code into its own subdirs which I believe was the original thought on >> how the code was to be structured. > > I think Peter made some suggestions about how to split things up... Yes, Peter has made some good suggestions and I'll work on splitting things up a bit more. Thanks, -stacey.
