On Jun 24, 2013, at 12:49 PM, Peter Maydell wrote: > On 24 June 2013 03:03, Stacey Son <s...@freebsd.org> wrote: >> This patch series add BSD user mode support for FreeBSD. In addition, >> it adds the necessary architecture dependent code for the mips, mips64, >> and arm targets. In its current state it can emulate most mips/mips64 >> and arm target binaries on a x86 host in a simple chroot environment >> (see https://wiki.freebsd.org/QemuUserModeHowTo for example). > >> Besides adding a lot of shims and other support code this change >> restructures the code significantly to reduce the amount of C >> preprocessor conditionals for the various target and host arch/OS's. >> In general, the target cpu depedent code has been moved into into >> the various arch directories and the host OS dependent code (ie. >> FreeBSD, NetBSD, OpenBSD) has been moved into the OS directories as >> much as possible. > >> 178 files changed, 23181 insertions(+), 2192 deletions(-) > > This is an awful lot of code to ask people to review. > Your patchset here is doing a lot of things: > * restructuring to put cpu dependent code into subdirs > * adding ARM support > * adding MIPS support > * adding support for lots of extra system calls > and it's also doing them all jumbled up together, and includes > individual patches which do more than one thing at once.
Sorry about that. Yes, this patch set is adding a lot of code. It has been maintained as a huge set patches in the FreeBSD qemu-devel port for some time but I finally cleaned it up and checkpatch.pl it all. > I'm not the bsd-user maintainer, but my suggestion would be > that you'll find it much easier to get your code submitted if > you try to get these various new features added one at a time > rather than all at once. Such as one system call shim at a time? That would be a lot of emails to this list. :) The patch set does break down the individual features into individual patches such as groups of system call shims. Of course, those patches are indeed still quite large. I do apologize for that. > PS: for future bsd-user patch submissions you should cc > Blue Swirl <blauwir...@gmail.com> who is the bsd-user maintainer > (see the MAINTAINERS file). Done. Thanks, -stacey.
