Stacey Son <s...@freebsd.org> writes: > On Jun 24, 2013, at 12:55 PM, Anthony Liguori wrote: > >> There is no humanly way 23k LOC can be reviewed in a single series. > > Yes, indeed, it is a lot of code. > >> Has this been maintained out of tree for some time? > > Yes, it has been a large, ugly patch set in the FreeBSD qemu-devel > port for some time.
Okay, I assume there were many collaborators then? You may want to consider collecting some additional Signed-off-bys then from the original authors. I don't like the idea merging a very large patch series without preserving authorship info. > >> Is it largely >> copy/paste from linux-user? > > A good amount of the initial code came from linux-user but then > diverged when the code was restructured to put cpu and *BSD dependent > code into its own subdirs which I believe was the original thought on > how the code was to be structured. I think Peter made some suggestions about how to split things up... Regards, Anthony Liguori > > Regards, > -stacey.
