On 05/13/2013 02:28 AM, Kevin Wolf wrote:
>>> +{ 'command': 'block-backup',
>>> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str',
>>
>> Hmm - wondering if we should add an enum type for supported disk formats
>> instead of using free-form strings. The wire representation would be
>> the same, and now's the time to do it before we add introspection (it's
>> more than just this command impacted).
>
> And ideally we shouldn't make it a static list that contains every
> format for which qemu has some code, but only those that are actually
> compiled in. (Hm, and probably not protocols?)
>
> Luiz, any idea how to do something like this, a QAPI enum with values
> that are determined at runtime? Especially with respect to the coming
> schema introspection?Or maybe we make the 'enum' list ALL possible types, but then add a query-* command that returns an array of only those enum values that are supported. Introspection would see all types, but the query command would be the useful variant that is runtime-dependent. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
