-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 11/05/2013 05:34, Eric Blake ha scritto: > On 05/08/2013 06:49 AM, Kevin Wolf wrote: >> Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: >>> @block-backup >>> > >> drive-backup would probably be a more consistent naming. We would >> then still have block-backup for a future low-level command that >> doesn't create everything by itself but takes an existing >> BlockDriverState (e.g. created by blockdev-add). > > At least it would match why we named a command 'drive-mirror' > instead of 'block-mirror'. > > Hmm, looking at qapi-schema.json, I wonder if we can rename > 'BlockdevAction' to 'TransactionAction' as used in the > @transaction command. It wouldn't change what is sent over the > wire in JSON, and until we have full introspection, there is no > visibility into the type name used. Changing the name now would > let it be more generic to adding future transaction items that are > not blockdev related.
Right. For example, "cont" could be made transactionable too (and executed only if the transaction succeeds). Paolo >> >> We should also make it transactionable from the beginning, as we >> don't have schema introspection yet. This way we allow to assume >> that if the standalone command exists, the transaction subcommand >> exists as well. > > Agreed - existence of a command at the same time the command is > made transactionable serves as a nice substitute for not having > full introspection into the 'BlockdevAction' union type, whereas if > we introduce the command now but not transaction support until 1.7, > life becomes tougher to know when it can be used where (although I > HOPE we have introspection in 1.6). > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRjfslAAoJEBvWZb6bTYbyiVkQAJpqoUcmTmzY9P8Me7pSlR5p MVogKDdvtFpr+GVWWaiykB4rN79gGjduOGHtMpScuE3Grr42nFSeGnJoKqKP788T 1ZCaEaOt/Il3PeGWJOM7y8RkxnieTOqehPIUODq/qHVKE+mN0+sFlvGI67lhQveI NWJCV2gzN6z7aCJE291BZxU4dtZzJv1SnkGqPZ2z/sEfQZulpVhmleE44SQRgFE1 oaSdfbniz/TRqmB5x8E3444X7YIZ9I+NTZuGlWr6V8tT9C5tnrB3jhMId9TVbQQg 2tDuYdm735kEC7K7byOtYWxJEKsEca/6dV5LbLh1gyoJWWb6/DM/bZ0je4XbtBFY sxbKAV2llDbBRa8yWkp7p+N9THARj00skb3u9rE38+UP9p7aQUW6ZXwsn0cawBec njDjdmnq4JiZQ+ez+wAFfxZmC1kx2Zfxsg/2aws67cf3ySzr14PSe0czgQaW0rgM BP+7W4pd6pGmrnK+ASEK2r2gWniiF1OyngV4Q3v6d7SIAkKU6fPcu5iY/9INveNv JRlMw/GE5/POENCuFhA6CEv/Dg48H6j9u9N44fC5i3KpS8mJaTn83av3MoBvAfqv JAH2ZNHxaK+HoV4oxSm4gbIehlI1gh19Mb08u226EdGYcupTkPvDnOU+GhJFEqoN 0nQLUIysLgHjGJzQtX1/ =ULCr -----END PGP SIGNATURE-----
