Il 27/03/2013 16:24, Igor Mammedov ha scritto: > I've put notifier in vl.c since most of them are there
They are there, because the code that invokes them is also there. In fact, most calls of notifier_list_notify in vl.c are from static functions. > Yep there wouldn't be need for stub if notifier is in qom/cpu.c, > but I've figured out that people would object to put it there > since it's build only once for softmmu and *-user targets and > *-user target doesn't need it at all. > > Andreas, > would it be acceptable if notifier goes in qom/cpu.c, (it would > add nop code to *-user target)? I think adding dead code to *-user is fine. >> > (Besides, I noticed now the get_icc_bus stub. I didn't understand why >> > it's used, but anyway adding CPU-specific stuff to libqemustub is >> > absolutely a no-no). > True, If icc_bus was created at board level then there wouldn't be any need > for get_icc_bus(), it could be just looked up in qom tree. I'll try to do it. > > BTW: is there any guidelines what might be added to libqemustub? Nothing. :) Seriously, you really should use it only when an entire subsystem does not exist in tools or user-level emulation (monitor, vm_clock, migration, slirp). Everything else will probably be served better by methods, in all likelihood. Paolo
