Eric Blake <ebl...@redhat.com> writes: > On 02/11/2013 08:06 PM, Michael R. Hines wrote: > > [no need to top-post on a technical list] > >> None of the other migration QMP commands use dashes. > > Then how do you explain 'query-migrate', 'migrate-set-capabilities', > 'query-migrate-capabilities', 'migrate-set-cache-size', > 'query-migrate-cache-size'? I argue that 'migrate_cancel' and > 'migrate_set_downtime' are the odd ones out, and only because they were > written before our current policy of preferring dash. > >> Shouldn't I stay consistent with the other commands? > > Yes, which is why I'm arguing for using dash.
Correct. Use dash instead of underscore for new commands and JSON object member names.
