None of the other migration QMP commands use dashes.
Shouldn't I stay consistent with the other commands?
If someone wants to re-work the migration command structure as a whole,
I'll certainly adapt to the new structure.....
On 02/11/2013 05:58 PM, Eric Blake wrote:
+++ b/qapi-schema.json
##
+# @migrate_set_rdma_port
New QMP commands should favor dash, not underscore. This should be
named 'migrate-set-rdma-port'; or perhaps we should consider a more
generic command 'migrate-set-parameter', which then takes a name/value
pair of which parameter to set, instead of having to add a new command
for every tweakable parameter.
If someone wants to re-work the migration command structure as a whole,
I'll certainly adapt to the new structure.....
+#
+# Set rdma communication port.
+#
+# @port: rdma communication port.
+#
+# Returns: nothing on success
+#
+# Notes: Nothing.
+#
+# Since: 1.3.0
1.5, at the earliest.
Acknowledged.