Hi Cédric, > From: Cédric Le Goater <c...@kaod.org> > Sent: Monday, July 28, 2025 2:50 PM > To: Michael Tokarev <m...@tls.msk.ru>; Jamin Lin > <jamin_...@aspeedtech.com>; Peter Maydell <peter.mayd...@linaro.org>; > Steven Lee <steven_...@aspeedtech.com>; Troy Lee <leet...@gmail.com>; > Andrew Jeffery <and...@codeconstruct.com.au>; Joel Stanley > <j...@jms.id.au>; open list:ASPEED BMCs <qemu-...@nongnu.org>; open > list:All patches CC here <qemu-devel@nongnu.org> > Cc: Troy Lee <troy_...@aspeedtech.com>; Hao Wu <wuhao...@google.com>; > Havard Skinnemoen <hskinnem...@google.com> > Subject: Re: [PATCH v1 19/21] pc-bios: Update AST27x0 vBootrom with SSP/TSP > SCU initialization support > > On 7/27/25 21:51, Michael Tokarev wrote: > > On 17.07.2025 06:40, Jamin Lin via wrote: > >> The updated boot ROM includes logic to initialize and enable SSP/TSP > >> using SCU registers, based on reserved-memory regions defined in the > device tree. > >> > >> Its source code is available at: > >> > https://github.com/google/vbootrom/commit/f9eb0bb57decbab860a81712c56 > >> 132c2102fa98e > > > > How to (re)build this one? > > This should be the same as npcm*xx_bootrom. > > > Please add build instructions to roms/Makefile. I dunno how this one > > is related to roms/vbootrom which is already used for > > npcmxxx_bootrom.bin files - maybe all the 3 bootroms should be kept in > sync. > > I think they are relatively independent. Each has its own directory. > > > Right now, with no instructions in roms/Makefile, it's problematic. > > Oh I missed that. My bad. > > Jamin, > > Can you please send an update asap ? >
It seems this patch fix this issue, https://patchwork.kernel.org/project/qemu-devel/patch/607a943a587248fbe0ff0897de80aee98a093caa.1753654515.git....@tls.msk.ru/ Do I need to update vbootrom/ast27x0/Makefile? I set "?=" to make user able to set variables in the command line. 1. export CC=aarch64-linux-gnu-gcc make 2. make CC=aarch64-linux-gnu-gcc 3. Update Make file and user only need to issue "make" diff --git a/ast27x0/Makefile b/ast27x0/Makefile index 5d13ba1..45c069a 100644 --- a/ast27x0/Makefile +++ b/ast27x0/Makefile @@ -13,11 +13,11 @@ # See the License for the specific language governing permissions and # limitations under the License. -CROSS_COMPILE ?= aarch64-linux-gnu- +CROSS_COMPILE = aarch64-linux-gnu- -CC ?= $(CROSS_COMPILE)gcc -OBJCOPY ?= $(CROSS_COMPILE)objcopy -OBJDUMP ?= $(CROSS_COMPILE)objdump +CC = $(CROSS_COMPILE)gcc +OBJCOPY = $(CROSS_COMPILE)objcopy +OBJDUMP = $(CROSS_COMPILE)objdump > Thanks, > > C. >
