On Sat, Jun 14, 2025 at 05:33:42PM +0200, Cédric Le Goater wrote: > Hello Sean, > > + Daniel > > On 6/14/25 14:58, Sean Wei wrote: > > Hi Cédric, > > > > Thank you for the quick review and for suggesting the SPDX approach. > > > > On Sat, Jun 14, 2025 at 1:36 AM Cédric Le Goater <c...@kaod.org> wrote: > > > > > > Instead, I would remove the license boiler plate and add : > > > > > > SPDX-License-Identifier: GPL-2.0-or-later > > > > > > > Before we respin the patch, could you please confirm the scope below? > > > > > > 1. For the two headers currently under review > > (aspeed_i2c.h and aspeed_timer.h) > > > > I will drop the multi-line GPL boiler-plate and replace it > > with SPDX line, while keeping the copyright statements. > > Fine with me. > > > 2. For the other ASPEED-maintained files > > > > hw/*/*aspeed* > > include/hw/*/*aspeed* > > tests/*/*aspeed* > > > > Would you prefer to convert them as well? If so, I'd prefer to > > send a dedicated patch series after this one. > > OK. As you wish. > > I think you can convert all QEMU files while at it. See: > > > https://lore.kernel.org/qemu-devel/20250519171004.352636-10-berra...@redhat.com/
Note that rules triggers *exclusively* for new files, not for any existing files. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
