On 12/05/2025 14.46, Gustavo Romero wrote:
Hi Thomas,
On 5/12/25 09:37, Thomas Huth wrote:
On 12/05/2025 14.08, Gustavo Romero wrote:
Hi Thomas,
Thanks for the review.
On 5/12/25 04:59, Thomas Huth wrote:
Hi!
On 10/05/2025 01.19, Gustavo Romero wrote:
Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and
hot-unplug on arm64. Currently, the aarch64 'virt' machine uses the PCIe
native controller and does not support ACPI-based hotplugging. However,
since support is planned, this test sets 'acpi=force' and specifies an
EDK2 firmware image in advance. This is harmless and prepares for future
ACPI support.
Signed-off-by: Gustavo Romero <gustavo.rom...@linaro.org>
---
tests/functional/meson.build | 1 +
tests/functional/test_aarch64_hotplug_pci.py | 73 ++++++++++++++++++++
2 files changed, 74 insertions(+)
create mode 100755 tests/functional/test_aarch64_hotplug_pci.py
Could you also add the test file to one of the sections in the
MAINTAINERS file, please?
Any idea under which section I should add this test?
Currently, it's only TCG, but in the future probably there will be
1) a variant with --enable-kvm option and 2) it will have a variant
with ACPI enabled. Hence, currently it doesn't seem to fit neither
under "PCI" nor under "ARM ACPI Subsystem", I think I can create a
section tho? Maybe "ARM PCI Hotplug"? Could you please advise?
A separate section likely only makes sense if there are other files that
you could add there. Otherwise, simply add it to the arm "Virt" machine
section?
hm but in this case wouldn't I be kind "forcing" Peter to maintain
this test? And, otoh, if I add me to "Virt" section then I'm saying that
I'll maintain all the other tests as well?
Ok, in that case a separate section makes sense ... Peter, do you have any
preferences?
Thomas
