Hi Thomas,

On 5/12/25 09:08, Gustavo Romero wrote:
Hi Thomas,

Thanks for the review.

On 5/12/25 04:59, Thomas Huth wrote:
  Hi!

On 10/05/2025 01.19, Gustavo Romero wrote:
Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and
hot-unplug on arm64. Currently, the aarch64 'virt' machine uses the PCIe
native controller and does not support ACPI-based hotplugging. However,
since support is planned, this test sets 'acpi=force' and specifies an
EDK2 firmware image in advance. This is harmless and prepares for future
ACPI support.

Signed-off-by: Gustavo Romero <gustavo.rom...@linaro.org>
---
  tests/functional/meson.build                 |  1 +
  tests/functional/test_aarch64_hotplug_pci.py | 73 ++++++++++++++++++++
  2 files changed, 74 insertions(+)
  create mode 100755 tests/functional/test_aarch64_hotplug_pci.py

Could you also add the test file to one of the sections in the MAINTAINERS 
file, please?

Any idea under which section I should add this test?

Currently, it's only TCG, but in the future probably there will be
1) a variant with --enable-kvm option and 2) it will have a variant
with ACPI enabled. Hence, currently it doesn't seem to fit neither
under "PCI" nor under "ARM ACPI Subsystem", I think I can create a
section tho? Maybe "ARM PCI Hotplug"? Could you please advise?

Well, I'll introduce all these variants into the test so I created a new
section "ARM PCI Hotplug" and added me as the maintainer. When I introduce
the variants I can change the section name to fit it better.

I just sent a v2.


Cheers,
Gustavo

Reply via email to