Hi!

On 10/05/2025 01.19, Gustavo Romero wrote:
Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and
hot-unplug on arm64. Currently, the aarch64 'virt' machine uses the PCIe
native controller and does not support ACPI-based hotplugging. However,
since support is planned, this test sets 'acpi=force' and specifies an
EDK2 firmware image in advance. This is harmless and prepares for future
ACPI support.

Signed-off-by: Gustavo Romero <gustavo.rom...@linaro.org>
---
  tests/functional/meson.build                 |  1 +
  tests/functional/test_aarch64_hotplug_pci.py | 73 ++++++++++++++++++++
  2 files changed, 74 insertions(+)
  create mode 100755 tests/functional/test_aarch64_hotplug_pci.py

Could you also add the test file to one of the sections in the MAINTAINERS file, please?

diff --git a/tests/functional/test_aarch64_hotplug_pci.py 
b/tests/functional/test_aarch64_hotplug_pci.py
new file mode 100755
index 0000000000..031540ba22
--- /dev/null
+++ b/tests/functional/test_aarch64_hotplug_pci.py
@@ -0,0 +1,73 @@
+#!/usr/bin/env python3
+#
+# The test hotplugs a PCI device and checks it on a Linux guest.
+#
+# Copyright (c) 2025 Linaro Ltd.
+#
+# Author:
+#  Gustavo Romero <gustavo.rom...@linaro.org>
+#
+# This work is licensed under the terms of the GNU GPL, version 2 or
+# later.  See the COPYING file in the top-level directory.
+
+from os import path
+from qemu_test import LinuxKernelTest, Asset, exec_command_and_wait_for_pattern
+from qemu_test import BUILD_DIR
+
+class HotplugPCI(LinuxKernelTest):
+
+    ASSET_KERNEL = Asset(
+        ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
+         'current/images/netboot/debian-installer/arm64/linux'),
+        '3821d4db56d42c6a4eac62f31846e35465940afd87746b4cfcdf5c9eca3117b2')
+
+    ASSET_INITRD = Asset(
+        ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
+         'current/images/netboot/debian-installer/arm64/initrd.gz'),
+        '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4')
+
+    def test_hotplug_pci(self):
+
+        self.vm.add_args('-m', '512M')
+        self.vm.add_args('-machine', 'type=virt')

Please use self.set_machine('virt') instead so that the test gets correctly skipped in case the machine has not been compiled into the binary.

 Thanks,
  Thomas


Reply via email to