On Wed, Apr 23, 2025 at 04:11:25PM +0800, Xiaoyao Li wrote: > Date: Wed, 23 Apr 2025 16:11:25 +0800 > From: Xiaoyao Li <xiaoyao...@intel.com> > Subject: Re: [PATCH v8 13/55] i386/tdx: Support user configurable > mrconfigid/mrowner/mrownerconfig > > On 4/22/2025 11:42 PM, Zhao Liu wrote: > > > diff --git a/qapi/qom.json b/qapi/qom.json > > > index f229bb07aaec..a8379bac1719 100644 > > > --- a/qapi/qom.json > > > +++ b/qapi/qom.json > > > @@ -1060,11 +1060,25 @@ > > > # pages. Some guest OS (e.g., Linux TD guest) may require this to > > > # be set, otherwise they refuse to boot. > > > # > > > +# @mrconfigid: ID for non-owner-defined configuration of the guest TD, > > > +# e.g., run-time or OS configuration (base64 encoded SHA384 digest). > > > +# Defaults to all zeros. > > > > Maybe a typo? s/Defaults/Default/ > > (It) defaults to all zeros. > > If you grep the "defaults to", you can get a lot of it.
The comment can be relaxed, but please try to be precise with the doc. You can add the omitted "It".
