On 4/22/2025 11:42 PM, Zhao Liu wrote:
diff --git a/qapi/qom.json b/qapi/qom.json
index f229bb07aaec..a8379bac1719 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -1060,11 +1060,25 @@
  #     pages.  Some guest OS (e.g., Linux TD guest) may require this to
  #     be set, otherwise they refuse to boot.
  #
+# @mrconfigid: ID for non-owner-defined configuration of the guest TD,
+#     e.g., run-time or OS configuration (base64 encoded SHA384 digest).
+#     Defaults to all zeros.

Maybe a typo? s/Defaults/Default/

(It) defaults to all zeros.

If you grep the "defaults to", you can get a lot of it.

+#
+# @mrowner: ID for the guest TD’s owner (base64 encoded SHA384 digest).
+#     Defaults to all zeros.

Ditto.

+#
+# @mrownerconfig: ID for owner-defined configuration of the guest TD,
+#     e.g., specific to the workload rather than the run-time or OS
+#     (base64 encoded SHA384 digest).  Defaults to all zeros.
+#
  # Since: 10.1
  ##
  { 'struct': 'TdxGuestProperties',
    'data': { '*attributes': 'uint64',
-            '*sept-ve-disable': 'bool' } }
+            '*sept-ve-disable': 'bool',
+            '*mrconfigid': 'str',
+            '*mrowner': 'str',
+            '*mrownerconfig': 'str' } }

Overall LGTM, (with Daniel's comment fixed,)

Reviewed-by: Zhao Liu <zhao1....@intel.com>




Reply via email to