[ .. ]
* Change looks okay. The header name 'migration.h' is rather generic, vfio-migration.h could be better. Looking at - #include "migration.h" - it is not clear which migration.h is being included. There is also a migration/migration.h header. But I'll leave that to you. (just sharing thoughts)
you are right. I am not satisfied with the header file names. It has been problematic and I would prefer all header files to have a "vfio-" prefix. Sadly, the gcc command line is making it difficult, or I misunderstood some parts. When using : #include "hw/vfio/foo.h" "hw/vfio/foo.h" could refer to either : ./hw/vfio/foo.h or ./include/hw/vfio/foo.h I find it confusing that we can include files from anywhere in the directory tree :/ May be call it "vfio-migration-internal.h" ? or use always : #include "hw/vfio/migration.h" (and remove -I .) ? Or rename the "include/hw/vfio/vfio-migration.h" file introduced in patch 3 for external migration services to some other name. Proposals welcome ! Thanks, C.
