Paolo Bonzini <pbonz...@redhat.com> writes:

> On Thu, Mar 6, 2025 at 5:16 PM Alex Bennée <alex.ben...@linaro.org> wrote:
>> +if get_option('debug')
>> +  qemu_cflags += get_option('split_debug') ? ['-gsplit-dwarf'] : ['-g']
>> +endif
>
> Since -g is already added by meson, it's enough to do
>
> -if get_option('debug')
> -  qemu_cflags += get_option('split_debug') ? ['-gsplit-dwarf'] : ['-g']
> +if get_option('debug') and get_option('split_debug')
> +  qemu_cflags += '-gsplit-dwarf'
>  endif
>
> Applied with this change, then.

Ahh I guess I was missing that meson does that under the hood. Can I
have a r-b with that change or do do you want to wait for v4?


>
> Paolo

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Reply via email to