On 3/3/25 16:48, Cédric Le Goater wrote:
On 3/3/25 16:26, BALATON Zoltan wrote:
On Mon, 3 Mar 2025, Cédric Le Goater wrote:
On 3/3/25 15:46, Paolo Bonzini wrote:
On 3/3/25 15:30, Philippe Mathieu-Daudé wrote:
I see PPC is defined in target/ppc/Kconfig so I think these mark the target not the host. Vfio-pci works with qemu-system-ppc

I've seen people do this on x86_64 host

Since this patch does:

   LINUX && PCI && (...  X86_64 ...)

these users won't see any change.

This is wrong---clearly this patch was never tested on the 32-bit platforms 
where it was supposed to have an effect.

euh it was.

With this patch, on 32-bit and 64-bit host systems :

 # build/qemu-system-i386 -device vfio-pci,?
 # qemu-system-i386: -device vfio-pci,?: Device 'vfio-pci' not found

Same for qemu-system-ppc and qemu-system-arm

What I am doing wrong ?

These QEMU targets aren't deprecated, compiling QEMU on 32 bit hosts is. But 
you can still use qemu-system-i386 and qemu-system-ppc on 64 bit hosts and 
vfio-pci works with these so it should not be disabled when building these QEMU 
targets. I think you meant to do something else not what this patch does.

I meant to remove all VFIO devices on 32-bit host platforms (which
is not needed anymore since 32-bit host platforms are dying anyway).

The patch is actually doing more, as it is removing VFIO devices for
32-bit targets too. That said, I doubt this config is tested at all
on i386. Something to add on the TODO list.

So,

    root@vm15:~# uname -a
    Linux vm15 6.10.12-686-pae #1 SMP PREEMPT_DYNAMIC Debian 6.10.12-1 
(2024-10-01) i686 GNU/Linux
    root@vm15:~# lspci -s 0000:01:00.0 -v
    01:00.0 Ethernet controller: Intel Corporation Ethernet Virtual Function 
700 Series (rev 02)
        Subsystem: Intel Corporation Device 0000
        Physical Slot: 0
        Flags: bus master, fast devsel, latency 0
        Memory at fba00000 (64-bit, prefetchable) [size=64K]
        Memory at fba10000 (64-bit, prefetchable) [size=16K]
        Capabilities: [70] MSI-X: Enable+ Count=5 Masked-
        Capabilities: [a0] Express Endpoint, IntMsgNum 0
        Capabilities: [100] Advanced Error Reporting
        Capabilities: [1a0] Transaction Processing Hints
        Capabilities: [1d0] Access Control Services
        Kernel driver in use: iavf
        Kernel modules: iavf
    root@vm15:~# ip link show dev enp1s0
    3: enp1s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP 
mode DEFAULT group default qlen 1000
        link/ether 06:0a:3d:59:01:11 brd ff:ff:ff:ff:ff:ff
        altname enx060a3d590111
It works well. I will make sure it continues to work.

Thanks,

C.



Reply via email to