On Mon, 3 Mar 2025, Philippe Mathieu-Daudé wrote:
On 26/2/25 18:57, BALATON Zoltan wrote:
On Wed, 26 Feb 2025, Cédric Le Goater wrote:
On 2/26/25 15:12, BALATON Zoltan wrote:
On Wed, 26 Feb 2025, Cédric Le Goater wrote:
VFIO PCI never worked on PPC32 nor ARM, S390x is 64-bit, it might have
worked on i386 long ago but we have no plans to further support VFIO
on any 32-bit host platforms. Restrict to 64-bit host platforms.

Cc: Harsh Prateek Bora <hars...@linux.ibm.com>
Cc: Tony Krowiak <akrow...@linux.ibm.com>
Cc: Eric Farman <far...@linux.ibm.com>
Cc: Eric Auger <eric.au...@redhat.com>
Signed-off-by: Cédric Le Goater <c...@redhat.com>
---
hw/vfio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/Kconfig b/hw/vfio/Kconfig
index 7cdba0560aa821c88d3420b36f86020575834202..6ed825429a9151fcdff33e95d1a310210689b258 100644
--- a/hw/vfio/Kconfig
+++ b/hw/vfio/Kconfig
@@ -7,7 +7,7 @@ config VFIO_PCI
    default y
    select VFIO
    select EDID
-    depends on LINUX && PCI
+    depends on LINUX && PCI && (AARCH64 || PPC64 || X86_64 || S390X)

Are these defined for the host or target?

host.

Where are these defined? I thought compiling qemu-system-ppc on x64_64 or aarch64 would have PPC defined not X86_64 or AARCH64 but I could well be missing something.

I see PPC is defined in target/ppc/Kconfig so I think these mark the target not the host. Vfio-pci works with qemu-system-ppc

Ah ! I am surprised. Which host and QEMU machine please ?

I've seen people do this on x86_64 host

Since this patch does:

 LINUX && PCI && (...  X86_64 ...)

these users won't see any change.

I still don't understand why. X86_64 is defined in target/i386/Kconfig. Isn't that only defined when building qemu-x86_64 or qemu-system-x86_64? Or is it also defined when building TCG on x86_64 host? This is confusing. docs/devel/tcg-ops.rst says "The TCG *target* is the architecture for which we generate the code. It is of course not the same as the "target" of QEMU which is the emulated architecture." Which of these is marked by these defines?

Regards,
BALATON Zoltan

Reply via email to