On Thu, Dec 5, 2024 at 5:30 AM Peter Xu <pet...@redhat.com> wrote: > > On Sun, Nov 17, 2024 at 08:20:00PM +0100, Maciej S. Szmigiero wrote: > > diff --git a/migration/colo.c b/migration/colo.c > > index 9590f281d0f1..a75c2c41b464 100644 > > --- a/migration/colo.c > > +++ b/migration/colo.c > > @@ -452,6 +452,9 @@ static int > > colo_do_checkpoint_transaction(MigrationState *s, > > bql_unlock(); > > goto out; > > } > > + > > + qemu_savevm_maybe_send_switchover_start(s->to_dst_file); > > + > > /* Note: device state is saved into buffer */ > > ret = qemu_save_device_state(fb); > > Looks all good, except I'm not sure whether we should touch colo. IIUC it > should be safer to remove it. >
Agree with Peter's comments. If I understand correctly, the current COLO doesn't support multifd migration. Thanks Chen > -- > Peter Xu > >