On 10/30/24 09:43, Alexander Graf wrote:
Hi,
sorry about the delay -- the patches failed CI and I didn't have much
time to investigate until now.
The issues are basically:
1) some rST syntax errors
2) failures on non-Linux due to lack of VHOST_USER
3) failures on 32-bit due to uint64_t/long mismatch.
While fixing (2) I also moved the dependency on libcbor and gnutls from
meson to Kconfig, and added --enable-libcbor to configure. I also split
hw/core/eif.c to a separate symbol, just to simplify reproducing the
32-bit failure on the right commit.
And finally, VIRTIO_NSM should default to no (the nitro-enclave machne
takes care of selecting it).
No big deal; it's easier done than described. See attached patch for
the differences.
Thanks a bunch for looking deeply and fixing the issues above :). I
suppose the next step is to post v9 with your changes included?
No, I can see that it wasn't clear but I've queued it. :)
Paolo
