Hey Paolo,
On 29.10.24 20:32, Paolo Bonzini wrote:
On 10/23/24 16:27, Dorjoy Chowdhury wrote:
On Wed, Oct 16, 2024 at 7:58 PM Dorjoy Chowdhury
<dorjoychy...@gmail.com> wrote:
Ping
This patch series has been reviewed by Alex. I am not sure if it needs
more review. If not, maybe this can be picked up for merging. Thanks!
Gentle ping.
This patch series has been reviewed by Alex and there hasn't been any
more reviews. it would be great if this could be picked up for
merging. Thanks!
Hi,
sorry about the delay -- the patches failed CI and I didn't have much
time to investigate until now.
The issues are basically:
1) some rST syntax errors
2) failures on non-Linux due to lack of VHOST_USER
3) failures on 32-bit due to uint64_t/long mismatch.
While fixing (2) I also moved the dependency on libcbor and gnutls from
meson to Kconfig, and added --enable-libcbor to configure. I also split
hw/core/eif.c to a separate symbol, just to simplify reproducing the
32-bit failure on the right commit.
And finally, VIRTIO_NSM should default to no (the nitro-enclave machne
takes care of selecting it).
No big deal; it's easier done than described. See attached patch for
the differences.
Thanks a bunch for looking deeply and fixing the issues above :). I
suppose the next step is to post v9 with your changes included?
Alex
Amazon Web Services Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597
