On 10/18/24 08:33, Akihiko Odaki wrote:
>> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
>> index 0d1de7dc398c..cfd4ed8a104f 100644
>> --- a/hw/display/virtio-gpu.c
>> +++ b/hw/display/virtio-gpu.c
>> @@ -1521,6 +1521,21 @@ void virtio_gpu_device_realize(DeviceState
>> *qdev, Error **errp)
>> #endif
>> }
>> + if (virtio_gpu_drm_enabled(g->parent_obj.conf)) {
>> +#ifdef VIRGL_VERSION_MAJOR
>
> This ifdef is unnecessary.
The VIRGL_VERSION_MAJOR is defined only when virtio-gpu is built with
enabled virgl support. It's necessary to have the ifdef, otherwise
you'll get a build failure when compiling QEMU with disabled virgl support.
--
Best regards,
Dmitry
