On Tue, Aug 27, 2024 at 09:00:35PM +0800, BillXiang wrote:
>
> > From: "Prasad Pandit"<ppan...@redhat.com>
> > Date: Tue, Aug 27, 2024, 20:37
> > Subject: Re: [PATCH v3] vhost-user: Do not wait for reply for not sent
> > VHOST_USER_SET_LOG_BASE
> > To: "BillXiang"<xiangwench...@dayudpu.com>
> > Cc: "Michael S. Tsirkin"<m...@redhat.com>, <qemu-devel@nongnu.org>
> > On Tue, 27 Aug 2024 at 16:50, BillXiang <xiangwench...@dayudpu.com> wrote:
> > > it's better to be consistent to use vhost_user_per_device_request for
> > > those per-device messages, right?
> >
> > * ...consistent to use? Could you please elaborate a little?
> >
> > Thank you.
> > ---
> > - Prasad
>
> That was elaborated in commit b931bfbf0429 (" vhost-user: add multiple queue
> support ").
> We have added vhost_user_one_time_request() to send those per-device messages
> only once
> for multi-queue device. Which was then changed to
> vhost_user_per_device_request() in
> commit 0dcb4172f2ce ("vhost-user: Change one_time to per_device request").
> And VHOST_USER_SET_LOG_BASE should be one of those per-device messages that
> only
> be sent once for multi-queue device.
Bill,
it's important to make it clear, in the commit message, what is the
current behaviour and what is the effect of the patch.
For example: currently qemu hangs waiting for ...., to fix,
.... so we never wait for .... .
At the moment, I'm not really sure if this is a bugfix, or
a cleanup, or what.
--
MST
