On Mon, 13 May 2024 at 11:36, Alistair Francis <alistai...@gmail.com> wrote: > > On Mon, May 13, 2024 at 4:32 PM Michael S. Tsirkin <m...@redhat.com> wrote: > > > > On Mon, May 13, 2024 at 01:55:50PM +1000, Alistair Francis wrote: > > > On Tue, May 7, 2024 at 3:24 PM Sia Jee Heng > > > <jeeheng....@starfivetech.com> wrote: > > > > > > Can you describe why you are doing this and that it will be reverted > > > in the commit message? > > > > > > Alistair > > > > What motivation are you asking? This follows the normal acpi test update > > procedure. > > I find it clearer to have commits describe that they are disabling > tests for a specific reason. That way it's easier to track what's > going on. > > If ACPI test updates don't usually do that then that's fine with me
The only reason for the existence of this ignore-these-blobs file is for the purpose of the commit sequence: * add the blobs to the whitelist * make a change that alters what the expected blobs are * regenerate the golden-reference blobs and remove the items from the whitelist So we don't usually say much in the commit that is adding a blob to the whitelist. thanks -- PMM
