On 3/23/2024 3:14 AM, Atish Kumar Patra wrote: > On Tue, Mar 12, 2024 at 6:53 AM Fei Wu <fei2...@intel.com> wrote: >> >> The RISC-V Server Platform specification[1] defines a standardized set >> of hardware and software capabilities, that portable system software, >> such as OS and hypervisors can rely on being present in a RISC-V server >> platform. >>
[...] >> + >> +static void finalize_fdt(RVSPMachineState *s) >> +{ >> + uint32_t phandle = 1, irq_mmio_phandle = 1, msi_pcie_phandle = 1; >> + uint32_t irq_pcie_phandle = 1; >> + >> + create_fdt_sockets(s, rvsp_ref_memmap, &phandle, &irq_mmio_phandle, >> + &irq_pcie_phandle, &msi_pcie_phandle); >> + >> + create_fdt_pcie(s, rvsp_ref_memmap, irq_pcie_phandle, msi_pcie_phandle); >> + >> + create_fdt_reset(s, rvsp_ref_memmap, &phandle); >> + >> + create_fdt_uart(s, rvsp_ref_memmap, irq_mmio_phandle); >> + >> + create_fdt_rtc(s, rvsp_ref_memmap, irq_mmio_phandle); > > > We need a minimalistic DT for firmwares which probably don't use rtc, pcie > etc. > Does EDK2 plan to generate ACPI tables from these DT ? Otherwise, we > can get rid of these. > Yes, I agree. Eventually we can remove many of these fdt when EDK2 is able to generate the ACPI tables directly. I add it here as EDK2 has not been adapted yet, the system won't boot up with the upstream EDK2 if e.g. fdt of pcie is removed. Thanks, Fei. > As Heinrich said, Linux kernels should boot using ACPI only. >