Dan Bode <d...@puppetlabs.com> wrote:
[...]
> > Comments about what I'm doing right and what I'm doing wrong would
> > be very welcome. I really want to know that everything's optimal
> > before investing time in publishing more modules, to not have to
> > later waste time going over all modules again.
> >
>
> The code is very easy to read and understand (which is one of the most
> important criteria)
Thanks. And I completely agree about the importance of readability :-)
> I have an implementation question:
>
> 1. Why are you doing the chkconfig exec:
>
> exec { "chkconfig ${title} on":
> notify => Service["xinetd"],
> path => [ "/sbin", "/bin" ],
> onlyif => "chkconfig --list ${title} | egrep -q 'off$'",
> }
>
>
> why doesnt:
>
> service { $title:
> enable => 'true'
> }
>
> work for this?
Fair question. I'm guessing that I assumed initially that the xinetd
"sub-services" wouldn't work with the puppet provider. I'm now guessing
that I should do some testing again and simplify this accordingly.
Thanks for the feedback : Exactly the kind I was ultimately looking for
by releasing my modules to the public! :-)
> If there are people familiar with puppetdoc here : Is it possible to
> > generate clean doc for my modules with only relative links to be
> > included in the repo?
>
> I do not understand this question.
Let me rephrase quickly : From a checkout inside ~/puppet-modules/ when
I run something like this :
puppetdoc --mode rdoc --outputdir ./doc \
--modulepath modules --manifestdir /var/empty
I then get html documentation inside ./doc/ but all of the manifests
files are referred to as /home/myuser/puppet-modules which would be
quite ugly if included in the git repo or on a website as documentation.
I've just tested with 2.6.8 and I still get the same result. There are
more details, like the module's main class showing up as xinetd::xinetd
instead of just xinetd or my definition's parameters needing to be
right after the "define" line (no empty line in between allowed) or the
documented #-- not working to stop further parsing...
Are others using puppetdoc for their modules? Are there some good
examples out there? The official documentation is useful but seems
somewhat limited.
Matthias
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
