On Sun, May 15, 2011 at 7:34 AM, Matthias Saou < th...@spam.spam.spam.spam.spam.spam.spam.egg.and.spam.freshrpms.net> wrote:
> Hi, > > I've been using puppet for a while now, and over time I've created many > classes and definitions for a whole bunch of different things. > It's all very RHEL4, RHEL5 (and now RHEL6) centric, but since lots of > people use that (or clones like CentOS), I'm sure it could all be reused > by many. The license will be Apache 2.0, just like puppet itself. > > Most of my ugly-ish code has already been cleaned up as modules, but in > order to release something really easy to be reused, I'm now looking > into the best way to document everything cleanly. The obvious choice > seems to be using puppetdoc, so I've started with a simple xinetd > module I had, making all of the relevant changes, and here is the > result : > > https://github.com/thias/puppet-modules > > Comments about what I'm doing right and what I'm doing wrong would be > very welcome. I really want to know that everything's optimal before > investing time in publishing more modules, to not have to later waste > time going over all modules again. > The code is very easy to read and understand (which is one of the most important criteria) I have an implementation question: 1. Why are you doing the chkconfig exec: exec { "chkconfig ${title} on": notify => Service["xinetd"], path => [ "/sbin", "/bin" ], onlyif => "chkconfig --list ${title} | egrep -q 'off$'", } why doesnt: service { $title: enable => 'true' } work for this? If there are people familiar with puppetdoc here : Is it possible to > generate clean doc for my modules with only relative links to be > included in the repo? I do not understand this question. > My testing with 0.25.5 (don't ask...) isn't going > so well. > > Matthias > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To post to this group, send email to puppet-users@googlegroups.com. > To unsubscribe from this group, send email to > puppet-users+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/puppet-users?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
