Todd Zullinger <t...@pobox.com> writes:

> One potential fix for that is to check for deletions, like so:

Thanks for doing work for us :)  We noticed the need for this but
haven't had a chance to fix it.  Your change works great.  I updated the
Wiki.

> One other potential problem is if puppet is used to manage selinux
> modules.  Compiled modules also have a .pp extension.  When adding or
> updating these files they will pass the "if [[ $name =~ [.]pp$ ]]"
> check.  This can be avoided by not version controlling the compiled
> modules, but perhaps it might also be reasonable to add a quick bit to
> the if test, something like this (untested):
>
>     if [[ $name =~ [.]pp$ ]] && [ "$(file -b "$name" 2>/dev/null)" != 'data' ]
>
> The selinux .pp files will return data, while I can't imaging any
> puppet manifests being labeled as data. :)

This sounds good to me but maybe it's not safe to assume GNU file (which
supports the -b) is installed on your puppetmaster?


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com
To unsubscribe from this group, send email to 
puppet-users+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/puppet-users?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to