On Fri, Apr 10, 2009 at 9:51 AM, David Lutterkort <lut...@redhat.com> wrote:
>
> On Thu, 2009-04-09 at 10:44 +1000, Karl Bowden wrote:
>> I've only been learning enough ruby for two days just to test the
>> augeas bindings, so mind the quality.
>
> Kudos to you :)
>
>> Attached is a bindings demo that shows how the bindings handle quotes,
>> and the output is below:
>
> The ruby bindings just pass the strings they get from Ruby through to
> the C library - they never try to interpret anything they see in those
> strings, and the results of your tests clearly show that.
>
>> And the augeas binding although not nessecaraly wrong, differs from
>> how augtool handles the same example:
>
> Therein lies the rub - augtool reads a line from the terminal (or a
> file) and needs to split it into individual tokens, similar to how the
> augeas provider does it, except it's much cruftier.
>
> I intend to make augtool to behave identical to the augeas provider to
> minimize confusion around quoting and all that when you go back and
> forth between trying things out in augtool and putting them into pupet
> manifests.
>
> David
@David:
I am quite happy with the way augtool parses commands and the changes
in the patch from Bryan now also make puppet more 'intelligent'. I
think that both the bindings and puppet do the right things, and am
happy either way for the parsing in augtool. The way augtool operates
currently seems most natural.
@Bryan:
I have attached a patch too, to be applied yours as I liked the
previous string trimming. It just made it easier to have more readable
puppet manifests and I cant really see any detriment to the strips.
You have made the right choices and requirements in your patch IMHO.
It makes augeas functions easier to read and the results more
predictable.
I have applied both patches to my 0.24.8 packages and finished
deployment without detriment.
Thank you all,
Karl
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en
-~----------~----~----~----~------~----~------~--~---
diff -aru a/puppet/provider/augeas/augeas.rb b/puppet/provider/augeas/augeas.rb
--- a/puppet/provider/augeas/augeas.rb 2009-04-10 18:32:17.000000000 +1000
+++ b/puppet/provider/augeas/augeas.rb 2009-04-10 18:33:19.000000000 +1000
@@ -62,9 +62,9 @@
end
if data.is_a?(String)
- s = data
+ s = data.strip()
data = []
- s.each_line { |line| data << line }
+ s.each_line { |line| data << line.strip() }
end
args = []
data.each do |line|
