absurdfarce commented on code in PR #1290:
URL:
https://github.com/apache/cassandra-python-driver/pull/1290#discussion_r3175142882
##########
tests/integration/standard/test_metadata.py:
##########
@@ -1087,14 +1087,6 @@ def test_export_keyspace_schema_udts(self):
Test udt exports
"""
- if PROTOCOL_VERSION < 3:
- raise unittest.SkipTest(
- "Protocol 3.0+ is required for UDT change events, currently
testing against %r"
- % (PROTOCOL_VERSION,))
-
- if sys.version_info[0:2] != (2, 7):
- raise unittest.SkipTest('This test compares static strings
generated from dict items, which may change orders. Test with 2.7.')
Review Comment:
This is certainly possible, but if we find ourselves in a situation where
our output changes because a particular version is handling dictionary keys
differently I would _much_ rather know that (by way of a failing test) than
silently skipping the test in question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
