absurdfarce commented on code in PR #1290:
URL:
https://github.com/apache/cassandra-python-driver/pull/1290#discussion_r3175136667
##########
tests/integration/standard/test_metadata.py:
##########
@@ -1639,12 +1631,12 @@ def test_function_cql_called_on_null(self):
kwargs['called_on_null_input'] = True
with self.VerifiedFunction(self, **kwargs) as vf:
fn_meta = self.keyspace_function_meta[vf.signature]
- self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*\)
CALLED ON NULL INPUT RETURNS .*")
+ self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*)
CALLED ON NULL INPUT RETURNS .*")
kwargs['called_on_null_input'] = False
with self.VerifiedFunction(self, **kwargs) as vf:
fn_meta = self.keyspace_function_meta[vf.signature]
- self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*\)
RETURNS NULL ON NULL INPUT RETURNS .*")
+ self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*)
RETURNS NULL ON NULL INPUT RETURNS .*")
Review Comment:
Three changes above were minor fixes to address some deprecation warnings
noted when running the test via Python 3.10:
```
tests/integration/standard/test_metadata.py:1591
/home/mersault/work/git/python-driver/tests/integration/standard/test_metadata.py:1591:
DeprecationWarning: invalid escape sequence '\('
self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*%s\(\) .*" %
kwargs['name'])
tests/integration/standard/test_metadata.py:1639
/home/mersault/work/git/python-driver/tests/integration/standard/test_metadata.py:1639:
DeprecationWarning: invalid escape sequence '\)'
self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*\) CALLED ON
NULL INPUT RETURNS .*")
tests/integration/standard/test_metadata.py:1644
/home/mersault/work/git/python-driver/tests/integration/standard/test_metadata.py:1644:
DeprecationWarning: invalid escape sequence '\)'
self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*\) RETURNS
NULL ON NULL INPUT RETURNS .*")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
