absurdfarce commented on PR #1290: URL: https://github.com/apache/cassandra-python-driver/pull/1290#issuecomment-4339038881
There are a number of other spots where sys.version_info is consulted to make decisions about functionality. It's true that all the rest of them are in test code but it might be a good idea to fix all of them in one go anyway: ``` $ rg version_info tests/unit/advanced/test_insights.py 66: if sys.version_info > (3,): tests/integration/advanced/graph/fluent/__init__.py 588: if sys.version_info >= (3, 0): tests/unit/test_policies.py 1297: if sys.version_info >= (3, 11): docs/api/cassandra.rst 6:.. data:: __version_info__ tests/unit/test_row_factories.py 31:NAMEDTUPLE_CREATION_BUG = sys.version_info >= (3,) and sys.version_info < (3, 7) cassandra/cluster.py 1427: if sys.version_info[0] >= 3 and sys.version_info[1] >= 7: tests/integration/standard/test_metadata.py 1095: if sys.version_info[0:2] != (2, 7): tests/integration/cqlengine/columns/test_validation.py 615: if sys.version_info < (3, 1): 739: if sys.version_info < (3, 1): tests/integration/cqlengine/base.py 51: if sys.version_info > (3, 0): ``` I can make the changes and push a commit to this branch if that's useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
