skoppu22 commented on code in PR #4737:
URL: https://github.com/apache/cassandra/pull/4737#discussion_r3101274496
##########
src/java/org/apache/cassandra/service/DataResurrectionCheck.java:
##########
@@ -158,6 +160,38 @@ static File getHeartbeatFile(Map<String, Object> config)
return heartbeatFile;
}
+ static long getMinimumThreshold(Map<String, Object> config)
+ {
+ String minimumThresholdConfigValue = (String)
config.get(MINIMUM_THRESHOLD_CONFIG_PROPERTY);
+ long minimumThresholdInMs;
+ if (minimumThresholdConfigValue != null)
+ {
+ try
+ {
+ minimumThresholdInMs = new
DurationSpec.IntMinutesBound(minimumThresholdConfigValue).to(MILLISECONDS);
Review Comment:
Looks like user cannot input value less than a minute. As gc_grace_seconds
is accepted in seconds, how about accepting minimum_threshold also in seconds
to be inline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
