smiklosovic commented on code in PR #4737:
URL: https://github.com/apache/cassandra/pull/4737#discussion_r3081963561
##########
src/java/org/apache/cassandra/service/DataResurrectionCheck.java:
##########
@@ -228,7 +264,7 @@ public void execute(StartupChecksConfiguration
configuration) throws StartupExce
continue;
long gcGraceMillis = ((long) userTable.gcPeriod) * 1000;
- if (heartbeatMillis + gcGraceMillis < currentTimeMillis)
+ if (heartbeatMillis + gcGraceMillis + minimumThreshold <
currentTimeMillis)
Review Comment:
@pauloricardomg yeah you can look at that like that too ... I just added
minimum to everything but I see your point. So on gc_grace 10 hours and min
threshold 3 hours, by your approach it would be 10h, by mine 13. On 0, it would
be still 3. I dont mind to do max(a,b). On default gc being I think 10 days or
so, the practical difference would be negligible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
