skoppu22 commented on code in PR #4737:
URL: https://github.com/apache/cassandra/pull/4737#discussion_r3101178026
##########
src/java/org/apache/cassandra/service/DataResurrectionCheck.java:
##########
@@ -228,7 +264,7 @@ public void execute(StartupChecksConfiguration
configuration) throws StartupExce
continue;
long gcGraceMillis = ((long) userTable.gcPeriod) * 1000;
- if (heartbeatMillis + gcGraceMillis < currentTimeMillis)
+ if (heartbeatMillis + Math.max(gcGraceMillis,
minimumThreshold) < currentTimeMillis)
Review Comment:
Can we rename minimumThreshold to something like minimumThresholdMillis
please, similar to other variables in this formula? That confirms to readers
that all are in millis, without having to check retrieval code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
