netudima commented on code in PR #4710: URL: https://github.com/apache/cassandra/pull/4710#discussion_r3067951986
########## src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java: ########## Review Comment: yes, it is overridden frequently for every row, so I think the benefit of early ref cleanup is low here, taking in account: - header is long living object - helper.in is also going to live together with helper after the re-use change in CASSANDRA-21296 - livenessInfo is light - builder is re-used for a partition also, technically writes are not totally free (due to GC barriers), so I would avoid extra ones for very frequent cell level logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
