frankgh commented on code in PR #4710:
URL: https://github.com/apache/cassandra/pull/4710#discussion_r3064177907
##########
src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java:
##########
@@ -626,20 +626,12 @@ public Row deserializeRowBody(DataInputPlus in,
try
{
- DataInputPlus finalIn = in;
Review Comment:
Can we instead iterate over all columns?
```java
for (ColumnMetadata column : columns)
{
if (column.isSimple())
readSimpleColumn(column, in, header, helper, builder,
livenessInfo);
else
readComplexColumn(column, in, header, helper,
hasComplexDeletion, builder, livenessInfo);
}
```
We don't even the wrapped exception here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
