maedhroz commented on code in PR #4710:
URL: https://github.com/apache/cassandra/pull/4710#discussion_r3066373955
##########
src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java:
##########
Review Comment:
nit: Given the helper doesn't already fall off the stack when this method is
done, we could add...
```
...
finally
{
// Avoid retaining references longer than necessary
helper.in = null;
helper.header = null;
helper.builder = null;
helper.livenessInfo = null;
}
```
I guess we'll just be overwriting these 4 every time we process a new row,
so maybe it's not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
