Patrick Ben Koetter:
> * Wietse Venema <postfix-users@postfix.org>:
> > Victor Duchovni:
> > > On Tue, Jan 18, 2011 at 03:56:45PM -0500, Wietse Venema wrote:
> > >
> > > > Something along the lines of:
> > > >
> > > > /*
> > > > * Workaround. The "," was already in use as dnsbl list separator.
> > > > */
> > > > for (keep = 0, cp = var_psc_dnsbl_sites; *cp; cp++) {
> > > > if (*cp == '[') {
> > > > keep++;
> > > > } else if (*cp == ']' && keep > 0) {
> > > > keep--;
> > > > } else if (*cp == ',' && keep <= 0) {
> > > > *cp = ' ';
> > > > }
> > > > }
> > > > dnsbl_site = argv_split(var_psc_dnsbl_sites, ", \t\r\n");
> > >
> > > Right, reasonably elegant, but with the split now on just " \t\r\n".
> >
> > But having "," inside an access control feature it is likely to
> > break third-party tools that maintain Postfix configuration files.
> >
> > The alternative is to change the address filter syntax, and to
> > replace "," by a different set separator such as ";".
>
> 2.9 is still release candidate. You could do that or does it break your rules?
The [x,x] syntax never worked in main.cf, so I can't break
configuration file compatibility by changing to [x;x].
But I would have to update a dozen regression tests that I wrote
for the code module that implements the address filter.
Wietse
