09.12.2024 21:52, Wietse Venema via Postfix-users wrote:
Michael Tokarev via Postfix-users:
Noticed a small error in postfix-script. The change is
in sed expression - 's/,/ /' vs 'y/,/ /'. This isn't
really important (it only suppresses extra check of
a few dirs which are normally done for default instance
only), but it's better to fix it.
You did not mention what the problem is. Is the problem that the
existing script does not replace multiple commas?
There's no problem per se, and I noted this in my initial email, -
it is very minor. If there are multiple directories listed there
delimited with commas, the script detects only the first dir as
a "nested" (non-default) multi-instance, and _omits_ some file
checking for it. But the code is written to suppress these file
checking for *all* nested multi-instances (but not for other non-
default instances). So it just spends a tiny number of extra
cycles for each but subsequent multi_instance_directories.
Also, just by reading the code, - if there's a warning about the
common-to-all instances files, this warning will be produced multiple
times, for default and for 2nd and remaining instances - it is
omitted only for the first one "subinstance" only.
I noted this just by reading the code, I haven't faced any problem.
After all this is not the most frequently used feature, and there
should be no warning either.
In that case I prefer 's/,/ /g' as that is more idiomatic for the
rest of Postfix code.
That's your call. The change is trivial either way. I'll just note
this for the future.
Thanks,
/mjt
_______________________________________________
Postfix-users mailing list -- postfix-users@postfix.org
To unsubscribe send an email to postfix-users-le...@postfix.org
